Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(radio): forward focus to native input #6274

Merged
merged 2 commits into from Aug 9, 2017
Merged

fix(radio): forward focus to native input #6274

merged 2 commits into from Aug 9, 2017

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Aug 4, 2017

fixes #6029

@mmalerba mmalerba requested a review from jelbourn August 4, 2017 15:53
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 4, 2017
devversion
devversion reviewed Aug 4, 2017
View reviewed changes
src/lib/radio/radio.ts Outdated
@@ -332,6 +332,7 @@ export const _MdRadioButtonMixinBase = mixinColor(mixinDisableRipple(MdRadioButt
'[class.mat-radio-checked]': 'checked',
'[class.mat-radio-disabled]': 'disabled',
'[attr.id]': 'id',
'(focus)': '_inputElement.nativeElement.focus()',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be really beneficial to have a comment for this. What do you think?

A comment that explains that normally the native element should be focused; But for the focus-trap there is an exception

devversion
devversion approved these changes Aug 4, 2017
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jelbourn
jelbourn approved these changes Aug 4, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
Copy link
Member

jelbourn commented Aug 4, 2017

@tinayuangao @devversion any idea what's up w/ the screenshots?

@mmalerba mmalerba added the Accessibility This issue is related to accessibility (a11y) label Aug 4, 2017
tinayuangao
tinayuangao approved these changes Aug 4, 2017
View reviewed changes
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 8, 2017
@mmalerba mmalerba merged commit cea4d9f into angular:master Aug 9, 2017
@mmalerba mmalerba deleted the radio branch April 3, 2018 15:19
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@tinayuangao tinayuangao tinayuangao approved these changes

Assignees

@jelbourn jelbourn

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Focus-trap start marker doesn't work when focus is redirected to an internal element
5 participants
@mmalerba @jelbourn @devversion @tinayuangao @googlebot