Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[autocomplete] invalid initially active option after escape #6258

Closed
willshowell opened this issue Aug 3, 2017 · 1 comment · Fixed by #6403
Closed

[autocomplete] invalid initially active option after escape #6258

willshowell opened this issue Aug 3, 2017 · 1 comment · Fixed by #6403
Assignees
@crisbeto

Comments

@willshowell
Copy link
Contributor

willshowell commented Aug 3, 2017 •
edited

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Opening the autocomplete doesn't initially show any items as active

What is the current behavior?

Closing an autocomplete via esc and then opening it again via down arrow key results in the first option being visibly active, but not selectable.

What are the steps to reproduce?

http://plnkr.co/edit/xXY6Gx88PUVCLI5MimtJ?p=preview
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 10, 2017
@crisbeto
fix(autocomplete): highlighted option not reset when closed with esca…
36836f4 
…pe key

Fixes the autocomplete active option not being reset when closing through the escape key. Previously the old active option would remain active upon reopening, however the user's focus would shift back to the top as soon as they press an arrow key.

Fixes angular#6258.
@crisbeto crisbeto mentioned this issue Aug 10, 2017
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 11, 2017
@crisbeto
fix(autocomplete): highlighted option not reset when closed with esca…
de6f383 
…pe or enter key

Fixes the autocomplete active option not being reset when closing through the escape or enter keys. Previously the old active option would remain active upon reopening, however the user's focus would shift back to the top as soon as they press an arrow key.

Fixes angular#6258.
andrewseguin pushed a commit that referenced this issue Aug 15, 2017
@crisbeto @andrewseguin
fix(autocomplete): highlighted option not reset when closed with esca…
bf59468 
…pe or enter key (#6403)

Fixes the autocomplete active option not being reset when closing through the escape or enter keys. Previously the old active option would remain active upon reopening, however the user's focus would shift back to the top as soon as they press an arrow key.

Fixes #6258.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@crisbeto @willshowell