Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[option/menu] hover and active background colors #6229

Closed
willshowell opened this issue Aug 2, 2017 · 3 comments · Fixed by #6302
Closed

[option/menu] hover and active background colors #6229

willshowell opened this issue Aug 2, 2017 · 3 comments · Fixed by #6302
Assignees

Comments

@willshowell
Copy link
Contributor

Bug, feature request, or proposal:

Styling issue

Current

  • the spec appears to show active option backgrounds at 12% opacity but currently they are 4%
  • active options have the same background opacity as hovered options

Expected

  • Active option backgrounds should be 12% opacity and either keep 4% for hover or remove it entirely

What are the steps to reproduce?

This shows how hovered options and active actions aren't distinguishable. Before hitting enter, I am not sure whether Hawaii or Indiana will be chosen.

autocomplete-option-hover

The following show the difference between the active select and the spec
screen shot 2017-08-02 at 2 13 16 pm
screen shot 2017-08-02 at 2 13 41 pm

@crisbeto
Copy link
Member

crisbeto commented Aug 4, 2017

It definitely looks darker, but where did you find the 12%? I'm trying to look through the spec, but I can't find specific numbers for the menu and select.

@willshowell
Copy link
Contributor Author

willshowell commented Aug 4, 2017

I measured the hex values with a color picker.

Menu panel: #FAFAFA
Active option: #DCDCDC

0xDC / 0xFA = 220 / 250 = 0.88

@crisbeto crisbeto self-assigned this Aug 6, 2017
@crisbeto crisbeto added the has pr label Aug 6, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 6, 2017
Darkens the selected option background in order to distinguish it from the ones that are focused or hovered.

Fixes angular#6229.
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 7, 2017
Darkens the selected option background in order to distinguish it from the ones that are focused or hovered.

Fixes angular#6229.
mmalerba pushed a commit that referenced this issue Aug 7, 2017
Darkens the selected option background in order to distinguish it from the ones that are focused or hovered.

Fixes #6229.
mmalerba pushed a commit that referenced this issue Aug 8, 2017
Darkens the selected option background in order to distinguish it from the ones that are focused or hovered.

Fixes #6229.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants