Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mdAutosizeMaxRows is doubled in Firefox #6179

Closed
mychalhackman opened this issue Jul 31, 2017 · 1 comment · Fixed by #6190
Closed

mdAutosizeMaxRows is doubled in Firefox #6179

mychalhackman opened this issue Jul 31, 2017 · 1 comment · Fixed by #6190
Assignees
@devversion

Comments

@mychalhackman
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

mdAutosizeMaxRows should limit textarea rows as expected across browsers.

What is the current behavior?

mdAutosizeMaxRows seems to be doubled in Firefox 54.0.1 on Windows 10

What are the steps to reproduce?

Add mdTextareaAutosize and mdAutosizeMaxRows="5" and test in Firefox.

  • Chrome, Opera, IE11 will stop growing at the amount of rows you have defined
  • Firefox appears to grow to maxRows x 2

https://plnkr.co/edit/6hKDXTJyA2Ytt0epMEMa?p=preview
firefox-double-rows

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular: 4.2.2
Material: 2.0.0-beta.7, 2.0.0-beta.8
OS: Windows 10
Typescript: 2.3.4
Browser: Firefox 54.0.1
@devversion devversion self-assigned this Jul 31, 2017
devversion added a commit to devversion/material2 that referenced this issue Aug 1, 2017
@devversion
fix(autosize): properly detect line-height on firefox
c67c23a 
In Firefox it happens that textarea elements are always bigger than the specified amount of rows. This is because Firefox tries to add extra space for the horizontal scrollbar.

As a workaround that removes the extra space for the scrollbar, we can just set overflow to hidden. This ensures that there is no invalid calculation of the line height.

See Firefox bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=33654

Fixes angular#6179
devversion added a commit to devversion/material2 that referenced this issue Aug 1, 2017
@devversion
fix(autosize): properly detect line-height in firefox
ea6c295 
In Firefox it happens that textarea elements are always bigger than the specified amount of rows. This is because Firefox tries to add extra space for the horizontal scrollbar.

As a workaround that removes the extra space for the scrollbar, we can just set overflow to hidden. This ensures that there is no invalid calculation of the line height.

See Firefox bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=33654

Fixes angular#6179
@devversion devversion mentioned this issue Aug 1, 2017
Merged
tinayuangao pushed a commit that referenced this issue Aug 1, 2017
@devversion @tinayuangao
fix(autosize): properly detect line-height in firefox
88b0644 
In Firefox it happens that textarea elements are always bigger than the specified amount of rows. This is because Firefox tries to add extra space for the horizontal scrollbar.

As a workaround that removes the extra space for the scrollbar, we can just set overflow to hidden. This ensures that there is no invalid calculation of the line height.

See Firefox bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=33654

Fixes #6179
tinayuangao pushed a commit that referenced this issue Aug 1, 2017
@devversion @tinayuangao
fix(autosize): properly detect line-height in firefox (#6190)
3a766f1 
* fix(autosize): properly detect line-height in firefox

In Firefox it happens that textarea elements are always bigger than the specified amount of rows. This is because Firefox tries to add extra space for the horizontal scrollbar.

As a workaround that removes the extra space for the scrollbar, we can just set overflow to hidden. This ensures that there is no invalid calculation of the line height.

See Firefox bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=33654

Fixes #6179

* Fix test name
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(autosize): properly detect line-height in firefox devversion/material2
2 participants
@devversion @mychalhackman