fix(dialog): better handling of custom ViewContainerRef with OnPush change detection #6164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
approved these changes
Jul 31, 2017
src/lib/dialog/dialog-container.ts
Outdated
| /** Starts the dialog exit animation. */ | ||
| _startExitAnimation(): void { | ||
| this._state = 'exit'; | ||
| this._changeDetectorRef.markForCheck(); |
There was a problem hiding this comment.
Add a comment that explains why this does markForCheck?
…hange detection * Adds a `markForCheck` call after starting the dialog animation, in order to ensure that it animates away if it was opened from a component with OnPush change detection. * Since we can't know whether the animation will start right after the `markForCheck`, these changes switch to starting the backdrop animation together with the dialog animation. This avoids some slight timing issues where the backdrop can start its animation a little too early. * Simplifies the dialog animation streams to avoid having to subscribe to the `completed` callback in the `MdDialogRef`. * Fixes the demo app sidenav jumping to the bottom when it is opened from the homepage. * Fixes some alignment in the dialog demo that got thrown off by the new input width. The dialog changes should solve issues like angular#5118.
crisbeto
force-pushed
the
dialog-onpush-animation
branch
from
5338d44
to
dcadc2d
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
markForCheckcall after starting the dialog animation, in order to ensure that it animates away if it was opened from a component with OnPush change detection.markForCheck, these changes switch to starting the backdrop animation together with the dialog animation. This avoids some slight timing issues where the backdrop can start its animation a little too early.completedcallback in theMdDialogRef.The dialog changes should solve issues like #5118.
@mmalerba I've reverted the changes from #6026 since it should work correctly with the
ViewContainerRefnow.