Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): underline should only be thicker if focused #6152

Merged
merged 1 commit into from Aug 1, 2017

Conversation

devversion
Copy link
Member

  • Currently the underline of the input container is always 2px thick if the input is invalid. As per specifications the underline should be 1dp/px if not focused.

@mmalerba The specs are not too clear about the intended behavior here. There are sections about the thickness of the underline, but not specifically in relation to error handling.

References #6140

* Currently the underline of the input container is always `2px` thick if the input is invalid. As per specifications the underline should be `1dp/px` if not focused.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 30, 2017
@mmalerba
Copy link
Contributor

I actually made this change intentionally (#4506) I agree that the spec isn't 100% clear, but I think they intended to make error state 2px always (see summary chart). Actually according to the chart hover state should be 2px too, which it currently isn't.

As for #6140, yes the select and the input currently differ in a number of ways that makes them look really bad when placed side by side. We need to refactor them to use the same CSS, I would like to use the CSS for the input since I've spent a lot of time making sure that it matches the spec relatively well.

@mmalerba
Copy link
Contributor

Ok given that the official spec is kind of vague on this I'm ok with changing it back to think only on focus. I think its better from an a11y standpoint for users to be able to visually distinguish focused from unfocused state.

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 31, 2017
@tinayuangao tinayuangao merged commit 68e2f46 into angular:master Aug 1, 2017
@devversion devversion deleted the fix/input-underline-thick branch November 11, 2017 10:22
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants