Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autocomplete): placeholder not resetting properly #6141

Merged
merged 1 commit into from Aug 2, 2017
Merged

fix(autocomplete): placeholder not resetting properly #6141

merged 1 commit into from Aug 2, 2017

Conversation

crisbeto
Copy link
Member

Fixes the following regressions that were introduced by the switch to OnPush change detection:

  • The floating placeholder not resetting when the user closes the panel without selecting a value.
  • The placeholder overlapping the input value when the autocomplete has a preselected value and floatPlaceholder="never".

@crisbeto
fix(autocomplete): placeholder not resetting properly
3a36281 
Fixes the following regressions that were introduced by the switch to OnPush change detection:
* The floating placeholder not resetting when the user closes the panel without selecting a value.
* The placeholder overlapping the input value when the autocomplete has a preselected value and `floatPlaceholder="never"`.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 29, 2017
mmalerba
mmalerba approved these changes Jul 31, 2017
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for input, will let @kara comment on autocomplete

@crisbeto crisbeto mentioned this pull request Jul 31, 2017
Closed
kara
kara approved these changes Aug 2, 2017
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added the action: merge The PR is ready for merge by the caretaker label Aug 2, 2017
@tinayuangao tinayuangao merged commit e4e7ee9 into angular:master Aug 2, 2017
@NqCompiler NqCompiler mentioned this pull request Aug 8, 2017
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@crisbeto @kara @mmalerba @googlebot @tinayuangao