New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(input): prevent input caret from sticking on iOS #6128
Conversation
// On some versions of iOS the caret gets stuck in the wrong place when holding down the delete | ||
// key. In order to get around this we need to "jiggle" the caret loose. Since this bug only | ||
// exists on iOS, we only bother to install the listener on iOS. | ||
if (_platform.IOS) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does mdInput do that causes this behavior in the first place? (vs. any other native input on ios)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's the fact that it causes relayout in response to input events sometimes (e.g. when showing errors) I created a minimal repro using native inputs which I posted on the associated bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack. Can file figure out if this is Safari specifically or Webkit in general? I suspect it's probably webkit, for which we can file a bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
fixes #5838