Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidenav container does not call markForCheck for lazy sidenavs #6127

Closed
willshowell opened this issue Jul 28, 2017 · 1 comment · Fixed by #6161
Closed

Sidenav container does not call markForCheck for lazy sidenavs #6127

willshowell opened this issue Jul 28, 2017 · 1 comment · Fixed by #6161
Assignees
@crisbeto @mmalerba
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@willshowell
Copy link
Contributor

Bug, feature request, or proposal:

Regression since #5731

Previous behavior

Styles were constantly checked due to sidenav container being Default.

Current behavior

Styles are only checked after markForCheck(), but markForCheck() is never called for changes on sidenavs that instantiate after ngAfterContentInit.

Reproduction

http://plnkr.co/edit/A13jf74fgDOssQitkGou?p=preview

cc @mmalerba @crisbeto
@mmalerba mmalerba added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Jul 28, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 31, 2017
@crisbeto
fix(sidenav): container not reacting to changes to sidenavs added aft…
b9da8a5 
…er init

Fixes the sidenav container not reacting to sidenavs that were added after initialization.

Fixes angular#6127.
@crisbeto crisbeto mentioned this issue Jul 31, 2017
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 1, 2017
@crisbeto
fix(sidenav): container not reacting to changes to sidenavs added aft…
43d8b3f 
…er init

Fixes the sidenav container not reacting to sidenavs that were added after initialization.

Fixes angular#6127.
tinayuangao pushed a commit that referenced this issue Aug 1, 2017
@crisbeto @tinayuangao
fix(sidenav): container not reacting to changes to sidenavs added aft…
0d80a77 
…er init (#6161)

Fixes the sidenav container not reacting to sidenavs that were added after initialization.

Fixes #6127.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

@mmalerba mmalerba

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sidenav): container not reacting to changes to sidenavs added after init crisbeto/material2
3 participants
@crisbeto @willshowell @mmalerba