Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable IE11 focus for MdCheckbox background SVG #6125

Closed
dmayala opened this issue Jul 28, 2017 · 1 comment · Fixed by #6137
Closed

Disable IE11 focus for MdCheckbox background SVG #6125

dmayala opened this issue Jul 28, 2017 · 1 comment · Fixed by #6137
Labels
Accessibility This issue is related to accessibility (a11y) P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@dmayala
Copy link

dmayala commented Jul 28, 2017

Bug, feature request, or proposal:

Bug

What is the expected behavior?

When pressing the tab in IE11, it should not focus on MdCheckbox's SVG background. This requires an additional tab press when using checkboxes.

What is the current behavior?

IE11 sets SVGs to focusable by default unlike Chrome and Firefox, so the tab focuses on the SVG background inside the checkbox.

What are the steps to reproduce?

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular 4, Material beta.8, Internet Explorer 11

Is there anything else we should know?

This is similar to this issue in the old version of the library. angular/material#7250
@jelbourn jelbourn added Accessibility This issue is related to accessibility (a11y) P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Jul 29, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 29, 2017
@crisbeto
fix(checkbox): remove checkmark from tab order
4b8faf1 
Prevents users from being able to tab into the underlying SVG checkmark on IE.

Fixes angular#6125.
@crisbeto crisbeto mentioned this issue Jul 29, 2017
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 29, 2017
@crisbeto
fix(progress-spinner): prevent users from tabbing into underlying SVG…
2984e2c 
… on IE

Since IE makes SVGs focusable by default, we need to disable it manually in order to prevent users from tabbing into it accidentally.

Relates to angular#6125.
@crisbeto crisbeto mentioned this issue Jul 29, 2017
Merged
tinayuangao pushed a commit that referenced this issue Jul 31, 2017
@crisbeto @tinayuangao
fix(checkbox): remove checkmark from tab order
452524c 
Prevents users from being able to tab into the underlying SVG checkmark on IE.

Fixes #6125.
tinayuangao pushed a commit that referenced this issue Aug 1, 2017
@crisbeto @tinayuangao
fix(checkbox): remove checkmark from tab order
b377691 
Prevents users from being able to tab into the underlying SVG checkmark on IE.

Fixes #6125.
tinayuangao pushed a commit that referenced this issue Aug 1, 2017
@crisbeto @tinayuangao
fix(progress-spinner): prevent users from tabbing into underlying SVG…
235f664 
… on IE (#6142)

Since IE makes SVGs focusable by default, we need to disable it manually in order to prevent users from tabbing into it accidentally.

Relates to #6125.
tinayuangao pushed a commit that referenced this issue Aug 1, 2017
@crisbeto @tinayuangao
fix(checkbox): remove checkmark from tab order (#6137)
735ffb5 
Prevents users from being able to tab into the underlying SVG checkmark on IE.

Fixes #6125.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(checkbox): remove checkmark from tab order crisbeto/material2
4 participants
@jelbourn @crisbeto @dmayala @tinayuangao