Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MdTextareaAutosize] - server side rendering crash #6047

Closed
jimjim2a opened this issue Jul 26, 2017 · 1 comment · Fixed by #6050
Closed

[MdTextareaAutosize] - server side rendering crash #6047

jimjim2a opened this issue Jul 26, 2017 · 1 comment · Fixed by #6050
Assignees

Comments

@jimjim2a
Copy link

Bug, feature request, or proposal:

Using MdTextareaAutosize directive make server side app crash at startup.

It crashes because when the ngAfterViewInit hook is called, some calculation based on the nativeElement are done.

What is the expected behavior?

If we are running on a server we should do nothing when the directive initializes itself, because all the calculation depends on an element already inserted into the DOM.

What is the current behavior?

The directive initializes itself, tries to autosize the textarea using some nativeElement methods and makes the app crash.

What are the steps to reproduce?

What is the use-case or motivation for changing an existing behavior?

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular 4.3.1
Material 2.0 beta 8
Typescript 2.3.3

Is there anything else we should know?

@crisbeto crisbeto self-assigned this Jul 26, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 26, 2017
Fixes a server-side rendering error when using the `mdTextareaAutosize` directive.

Fixes angular#6047.
andrewseguin pushed a commit that referenced this issue Jul 27, 2017
Fixes a server-side rendering error when using the `mdTextareaAutosize` directive.

Fixes #6047.
andrewseguin pushed a commit that referenced this issue Jul 27, 2017
Fixes a server-side rendering error when using the `mdTextareaAutosize` directive.

Fixes #6047.
andrewseguin pushed a commit that referenced this issue Jul 27, 2017
Fixes a server-side rendering error when using the `mdTextareaAutosize` directive.

Fixes #6047.
andrewseguin pushed a commit that referenced this issue Jul 28, 2017
…ize (#6050)

Fixes a server-side rendering error when using the `mdTextareaAutosize` directive.

Fixes #6047.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants