Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button-toggle): remove emit change event when value changes #6034

Merged
merged 1 commit into from Jul 28, 2017
Merged

fix(button-toggle): remove emit change event when value changes #6034

merged 1 commit into from Jul 28, 2017

Conversation

tinayuangao
Copy link
Contributor

@tinayuangao tinayuangao commented Jul 25, 2017 •
edited

Closes #5880

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 25, 2017
@tinayuangao tinayuangao force-pushed the button-toggle-emit branch 2 times, most recently from 1f9b867 to 283e0ba Compare July 25, 2017 20:57
jelbourn
jelbourn approved these changes Jul 27, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 27, 2017
@andrewseguin andrewseguin merged commit f8c5be8 into angular:master Jul 28, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

md-button-toggle-group trigger change event when it should not
4 participants
@tinayuangao @jelbourn @googlebot @andrewseguin