Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Expansion] Standalone panel inconsistently overrides margin when collapsed vs expanded #5949

Closed
willshowell opened this issue Jul 21, 2017 · 1 comment · Fixed by #5962
Closed
Assignees

Comments

@willshowell
Copy link
Contributor

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Margin set on a standalone expansion panel should not be overridden when collapsed. Alternatively, I would expect it to be overridden consistently in collapsed and expanded states.

What is the current behavior?

When collapsed, the panel has an margin of 0 applied via inline style. When expanded, no inline styles exist.

For reference:

    trigger('displayMode', [
      state('collapsed', style({margin: '0'})),
      state('default', style({margin: '16px 0'})),
      state('flat', style({margin: '0'})),
      transition(...)
    ]
  /** Gets the panel's display mode. */
  _getDisplayMode(): MdAccordionDisplayMode | MdExpansionPanelState {
    if (!this.expanded) {
      return this._getExpandedState();
    }
    if (this.accordion) {
      return this.accordion.displayMode;
    }
    return this._getExpandedState();
  }

  /** Gets the expanded state string. */
  _getExpandedState(): MdExpansionPanelState {
    return this.expanded ? 'expanded' : 'collapsed';
  }

As you can see, there is no handling of the state being 'expanded'

What are the steps to reproduce?

http://plnkr.co/edit/Oscu0l2jPi7W2HGmh5yv?p=preview

What is the use-case or motivation for changing an existing behavior?

Obviously I could wrap it in a container and add a margin to that, but it seems that inconsistent behavior in different states is undesirable.

@willshowell willshowell changed the title Standalone expansion panel unnecessarily overrides margin when collapsed [Expansion] Standalone panel inconsistently overrides margin when collapsed vs expanded Jul 21, 2017
@crisbeto crisbeto self-assigned this Jul 22, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 22, 2017
Previously, a standalone expansion panel would transition from `margin: 0` not no set margin, which causes inconsistent behavior of the consumer specified a custom margin on it. These changes make it so it doesn't override the margin at all, unless it's a part of an accordion.

Fixes angular#5949.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 22, 2017
Previously, a standalone expansion panel would transition from `margin: 0` not no set margin, which causes inconsistent behavior of the consumer specified a custom margin on it. These changes make it so it doesn't override the margin at all, unless it's a part of an accordion.

Fixes angular#5949.
andrewseguin pushed a commit that referenced this issue Jul 27, 2017
)

Previously, a standalone expansion panel would transition from `margin: 0` not no set margin, which causes inconsistent behavior of the consumer specified a custom margin on it. These changes make it so it doesn't override the margin at all, unless it's a part of an accordion.

Fixes #5949.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants