feat(button-toggle): Add aria-label and aria-labelledby to button toggle #5919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tinayuangao
added
Accessibility
jelbourn
approved these changes
Jul 21, 2017
There was a problem hiding this comment.
LGTM, this is a good change for the current approach.
FYI if we have time in the quarter, I'd like to explore changing these toggles to align with https://inclusive-components.design/toggle-button/
| let fixture = TestBed.createComponent(ButtonToggleWithAriaLabel); | ||
| checkboxDebugElement = fixture.debugElement.query(By.directive(MdButtonToggle)); | ||
| checkboxNativeElement = checkboxDebugElement.nativeElement; | ||
| inputElement = <HTMLInputElement>checkboxNativeElement.querySelector('input'); |
There was a problem hiding this comment.
Prefer the as coercion syntax:
inputElement = checkboxNativeElement.querySelector('input') as HTMLInputElement;
tinayuangao
force-pushed
the
button-toggle-a11y
branch
from
e152794
to
e097b81
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.