Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(option): support for disableRipple binding #5915

Merged
merged 1 commit into from Jul 21, 2017

Conversation

devversion
Copy link
Member

  • Allows disabling ripples for md-option elements.

Note: As part of #5801 it might make sense in the future (as a follow up) to support disabling ripples for all options by applying the disableRipple binding on the md-select itself. Anyway this PR would be the base to support such a functionality.

References #5801

* Allows disabling ripples for md-option elements.

References angular#5801
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 20, 2017
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 21, 2017
@kara kara removed their assignment Jul 21, 2017
@kara kara merged commit addf1ce into angular:master Jul 21, 2017
@devversion devversion deleted the feat/disable-ripple-option branch November 11, 2017 10:22
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants