Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(menu): make it easier to override elevation #5873

Merged
merged 1 commit into from Jul 20, 2017
Merged

fix(menu): make it easier to override elevation #5873

merged 1 commit into from Jul 20, 2017

Conversation

crisbeto
Copy link
Member

Makes it a little easier to override the elevation of the .mat-menu-panel. Previously it wasn't possible to apply the mat-elevation-z* classes directly, because the elevation styles are defined earlier in the stylesheet than the menu styles.

Fixes #5870.

@crisbeto
fix(menu): make it easier to override elevation
b1e1203 
Makes it a little easier to override the elevation of the `.mat-menu-panel`. Previously it wasn't possible to apply the `mat-elevation-z*` classes directly, because the elevation styles are defined earlier in the stylesheet than the menu styles.

Fixes angular#5870.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 19, 2017
kara
kara approved these changes Jul 19, 2017
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 19, 2017
@kara kara removed their assignment Jul 19, 2017
@kara kara merged commit 6f5dcd5 into angular:master Jul 20, 2017
@willshowell willshowell mentioned this pull request Jul 28, 2017
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MdMenu : style mat-menu-panel
3 participants
@crisbeto @kara @googlebot