feat: add change emitters to the Intl providers #5867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
andrewseguin
approved these changes
Jul 21, 2017
|
LGTM. I really hope we switch to something better in the future though, this was already not a great experience for users and now it's even worse. |
mmalerba
added
pr: lgtm
action: merge
|
I agree @mmalerba. An alternative can be not to encourage people to override the whole provider, but rather have an injectable with an |
crisbeto
force-pushed
the
5738/intl-changes
branch
from
ed409cd
to
ef75cb6
Compare
|
Needs rebase |
Since we're switching all components to OnPush change detection, they won't necessarily react to dynamic changes in the i18n labels. These changes add an `EventEmitter` per provider that allow for components to react to those types of changes. Note that it's up to the consumer to call `provider.changes.emit()` in order to trigger the re-render. Fixes angular#5738.
crisbeto
force-pushed
the
5738/intl-changes
branch
from
ef75cb6
to
12c6cfd
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're switching all components to OnPush change detection, they won't necessarily react to dynamic changes in the i18n labels. These changes add an
EventEmitterper provider that allow for components to react to those types of changes. Note that it's up to the consumer to callprovider.changes.emit()in order to trigger the re-render.Fixes #5738.