Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(paginator): default page size to first option #5822

Merged
merged 4 commits into from Jul 25, 2017

Conversation

andrewseguin
Copy link
Contributor

If no page size is provided, use the first option in the list of options.

Note that markForCheck has been added to each @Input since they may be changed directly rather than through templating. This fixed the test should be able to go to the previous page which changed pageIndex to 1 but the paginator never re-evaluated its template because the input was changed directly in the MdPaginator.

Fixes #5767

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 17, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 25, 2017
@andrewseguin andrewseguin merged commit 42c50b6 into angular:master Jul 25, 2017
@andrewseguin andrewseguin deleted the paginator-options branch November 28, 2017 20:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[md-paginator] pageSize keeps default of 50 even if pageSizeOptions only has 1 option which is not 50
3 participants