Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input): add overflow:hidden when calculating autosize height #5773

Merged
merged 2 commits into from Jul 20, 2017
Merged

fix(input): add overflow:hidden when calculating autosize height #5773

merged 2 commits into from Jul 20, 2017

Conversation

mmalerba
Copy link
Contributor

fixes #4948

@mmalerba mmalerba requested a review from jelbourn July 14, 2017 21:11
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 14, 2017
jelbourn
jelbourn reviewed Jul 14, 2017
View reviewed changes
src/lib/input/autosize.ts
textarea.style.height = 'auto';
textarea.style.overflow = 'hidden';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to write a unit test for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could find some text that previously wasn't calculated right and check that its height is correct now I suppose

jelbourn
jelbourn approved these changes Jul 14, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 14, 2017
@kara kara merged commit e0fc526 into angular:master Jul 20, 2017
@mmalerba mmalerba deleted the input-resize branch April 3, 2018 15:18
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MdTextareaAutosize: textarea control not sized correctly when number of lines is an odd number
4 participants
@mmalerba @jelbourn @kara @googlebot