Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating label for autocomplete does not animate on focus #5755

Closed
grizzm0 opened this issue Jul 14, 2017 · 3 comments · Fixed by #3992
Closed

Floating label for autocomplete does not animate on focus #5755

grizzm0 opened this issue Jul 14, 2017 · 3 comments · Fixed by #3992
Assignees

Comments

@grizzm0
Copy link
Contributor

grizzm0 commented Jul 14, 2017

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Floating label should float using animation on fucs.

What is the current behavior?

Floating label snaps to floating-position without animation.

What are the steps to reproduce?

http://plnkr.co/edit/mVEqWQ3Xp4Ieep3iDs96?p=preview

What is the use-case or motivation for changing an existing behavior?

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Is there anything else we should know?

@crisbeto
Copy link
Member

Should be resolved by #3992.

@grizzm0
Copy link
Contributor Author

grizzm0 commented Jul 14, 2017

@crisbeto Could you edit your PR to include "Fixes" and a link to this issue? I created an issue as I didn't find one. Might aswell keep this open until your PR is merged.

crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 14, 2017
Fixes the placeholder not being animated on focus.

**Note:** The `_handleFocus` and `openPanel` methods do pretty much the same (aside from the extra boolean), but I wanted to avoid having to pass the `$event` to `openPanel` since the event isn't really relevant to the API for opening the autocomplete programmatically.

Fixes angular#5755.
@crisbeto crisbeto self-assigned this Jul 14, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 20, 2017
Fixes the placeholder not being animated on focus.

**Note:** The `_handleFocus` and `openPanel` methods do pretty much the same (aside from the extra boolean), but I wanted to avoid having to pass the `$event` to `openPanel` since the event isn't really relevant to the API for opening the autocomplete programmatically.

Fixes angular#5755.
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 20, 2017
Fixes the placeholder not being animated on focus.

**Note:** The `_handleFocus` and `openPanel` methods do pretty much the same (aside from the extra boolean), but I wanted to avoid having to pass the `$event` to `openPanel` since the event isn't really relevant to the API for opening the autocomplete programmatically.

Fixes angular#5755.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants