fix(datepicker): force Intl.DateTimeFormat to use UTC time zone ... #5747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doesn't display incorrect dates.
googlebot
added
the
cla: yes
crisbeto
added
pr: lgtm
action: merge
|
@mmalerba seems like there's a linting error and the output format is different on iOS Safari. |
|
lint + tests fixed |
kara
reviewed
Jul 19, 2017
| date = new Date(Date.UTC( | ||
| date.getFullYear(), date.getMonth(), date.getDate(), date.getHours(), | ||
| date.getMinutes(), date.getSeconds(), date.getMilliseconds())); | ||
| displayFormat = Object.assign({}, displayFormat, {timeZone: 'utc'}); |
There was a problem hiding this comment.
@mmalerba Object.assign is breaking in Google. Can you switch to our util extendObject?
kara
added
presubmit failures
mmalerba
added
action: merge
|
fixed |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so it doesn't display incorrect dates.
fixes #5185
@julianobrasil Thanks for tracking down the root issue!