fix(datepicker): remove aria-expanded on datepicker input ... #5746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Jul 14, 2017
| '[attr.aria-haspopup]': 'true', | ||
| '[attr.aria-owns]': '_datepicker?.id', | ||
| '[attr.aria-owns]': '_datepicker?.opened && _datepicker.id', |
attribute is not supported for text inputs. also only set aria-owns attribute when the datepicker is open and therefore actually in the DOM.
|
done, and caught a bug \o/ |
jelbourn
added
pr: lgtm
action: merge
kara
changed the title
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since the attribute is not supported for text inputs. also only set aria-owns
attribute when the datepicker is open and therefore actually in the DOM.
fixes #5730
fixes #5729