Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression - sidenav first animation skipped #5673

Closed
amitport opened this issue Jul 11, 2017 · 3 comments · Fixed by #5821
Closed

regression - sidenav first animation skipped #5673

amitport opened this issue Jul 11, 2017 · 3 comments · Fixed by #5821
Assignees
@crisbeto

Comments

@amitport
Copy link
Contributor

amitport commented Jul 11, 2017 •
edited

Bug, feature request, or proposal:

the first sidnav animation is skipped when used inside a route

What is the expected behavior?

should animate

What are the steps to reproduce?

http://plnkr.co/edit/b8e2dBj4K4PrYHKBBxa5

What is the use-case or motivation for changing an existing behavior?

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

angular 4.2.6
material 2.0.0-beta.8
chrome 59
TypeScript 2.3.3

Is there anything else we should know?

not reproduced with angular 4.1
after the first sidenav close/open, animations work properly
@grizzm0
Copy link
Contributor

grizzm0 commented Jul 11, 2017 •
edited

.mat-sidenav-transition doesn't get added to md-sidenav-container upon init.
Seems to be related to this row.

@peluprvi
Copy link

I was having the same behavior and it fixed after updating to the new master a34787d.

@crisbeto crisbeto self-assigned this Jul 17, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 17, 2017
@crisbeto
fix(sidenav): first animation not working in Angular 4.2+
1a31d66 
Fixes the first opening/closing animation not working in newer Angular versions. The issue is due to the fact that Angular no longer evaluates the `_enableTransitions` binding after we've set it in the microtask empty callback. These changes switch to setting the class directly, which also has the advantage of being a little more compact.

Fixes angular#5673.
@crisbeto crisbeto mentioned this issue Jul 17, 2017
Merged
kara pushed a commit that referenced this issue Jul 20, 2017
@crisbeto @kara
fix(sidenav): first animation not working in Angular 4.2+
d371cf7 
Fixes the first opening/closing animation not working in newer Angular versions. The issue is due to the fact that Angular no longer evaluates the `_enableTransitions` binding after we've set it in the microtask empty callback. These changes switch to setting the class directly, which also has the advantage of being a little more compact.

Fixes #5673.
kara pushed a commit that referenced this issue Jul 20, 2017
@crisbeto @kara
fix(sidenav): first animation not working in Angular 4.2+ (#5821)
804f4c0 
Fixes #5673
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sidenav): first animation not working in Angular 4.2+ crisbeto/material2
4 participants
@amitport @peluprvi @grizzm0 @crisbeto