Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(expansion): toggle icon not being updated #5623

Closed
julianobrasil opened this issue Jul 9, 2017 · 2 comments · Fixed by #5650
Closed

bug(expansion): toggle icon not being updated #5623

julianobrasil opened this issue Jul 9, 2017 · 2 comments · Fixed by #5650
Assignees
@crisbeto

Comments

@julianobrasil
Copy link
Contributor

julianobrasil commented Jul 9, 2017 •
edited

Bug, feature request, or proposal:

bug

What is the expected behavior?

If you switch the expanded input from false-true-false... the toggle icon on the upper right corner should change it's direction.

What is the current behavior?

It's not changing, unless you click on the expansion header

What are the steps to reproduce?

At the plunker, click on the toggle panel button bellow the expansion to switch its state and watch the not-changing toggle icon.

Plunker: https://plnkr.co/edit/SIkVCu?p=preview

What is the use-case or motivation for changing an existing behavior?

Programmatically open and close the expansion

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Material latest builds

Is there anything else we should know?

expanded == true

image

expanded == false

image
@devversion devversion self-assigned this Jul 9, 2017
@julianobrasil julianobrasil changed the title bug(expansion): toogle icon not being updated bug(expansion): toggle icon not being updated Jul 9, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 10, 2017
@crisbeto
fix(expansion-panel): toggle not being updated when set programmatically
abd3779 
Fixes the toggle arrow not being flipped when the `expanded` is set programmatically, in addition to the `hideToggle` input not working either. This is a regression from angular#5549 and is a consequence of the fact that the panel header reaches into the panel to determine what to do with the arrow.

Fixes angular#5623.
@crisbeto
Copy link
Member

Picking this one up as per chat with @devversion.

@crisbeto crisbeto assigned crisbeto and unassigned devversion Jul 10, 2017
@crisbeto crisbeto mentioned this issue Jul 10, 2017
Merged
@crisbeto crisbeto marked this as a duplicate of #5926 Jul 21, 2017
@crisbeto crisbeto mentioned this issue Jul 21, 2017
Closed
@julianobrasil julianobrasil mentioned this issue Jul 21, 2017
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 25, 2017
@crisbeto
fix(expansion-panel): toggle not being updated when set programmatically
d58124c 
Fixes the toggle arrow not being flipped when the `expanded` is set programmatically, in addition to the `hideToggle` input not working either. This is a regression from angular#5549 and is a consequence of the fact that the panel header reaches into the panel to determine what to do with the arrow.

Fixes angular#5623.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 26, 2017
@crisbeto
fix(expansion-panel): toggle not being updated when set programmatically
ff4ea0a 
Fixes the toggle arrow not being flipped when the `expanded` is set programmatically, in addition to the `hideToggle` input not working either. This is a regression from angular#5549 and is a consequence of the fact that the panel header reaches into the panel to determine what to do with the arrow.

Fixes angular#5623.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 27, 2017
@crisbeto
fix(expansion-panel): toggle not being updated when set programmatically
0342642 
Fixes the toggle arrow not being flipped when the `expanded` is set programmatically, in addition to the `hideToggle` input not working either. This is a regression from angular#5549 and is a consequence of the fact that the panel header reaches into the panel to determine what to do with the arrow.

Fixes angular#5623.
andrewseguin pushed a commit that referenced this issue Jul 28, 2017
@crisbeto @andrewseguin
fix(expansion-panel): toggle not being updated when set programmatica…
41c804b 
…lly (#5650)

* fix(expansion-panel): toggle not being updated when set programmatically

Fixes the toggle arrow not being flipped when the `expanded` is set programmatically, in addition to the `hideToggle` input not working either. This is a regression from #5549 and is a consequence of the fact that the panel header reaches into the panel to determine what to do with the arrow.

Fixes #5623.

* chore: add a couple of unit tests for the fixes
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(expansion-panel): toggle not being updated when set programmatically crisbeto/material2
3 participants
@crisbeto @devversion @julianobrasil