Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Md-autocomplete always hidden when used with md-optgroup #5581

Closed
alex321 opened this issue Jul 7, 2017 · 2 comments · Fixed by #5604
Closed

Md-autocomplete always hidden when used with md-optgroup #5581

alex321 opened this issue Jul 7, 2017 · 2 comments · Fixed by #5604
Assignees
@crisbeto
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix

Comments

@alex321
Copy link

alex321 commented Jul 7, 2017 •
edited

Feature:

Autocomplete is hidden when the dropdown contains an md-optgroup with md-option inside it.

What is the expected behavior?

Autocomplete should be compatible with md-optgroup.

What are the steps to reproduce?

The md-autocomplete stays hidden as shown in this plunker:

https://plnkr.co/edit/JIU35gPRfqDaBBwzMG6S?p=preview

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Material: 2.0.0-beta.8
@crisbeto crisbeto self-assigned this Jul 8, 2017
@crisbeto crisbeto added feature This issue represents a new feature or feature request rather than a bug or bug fix has pr labels Jul 8, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 8, 2017
@crisbeto
feat(autocomplete): support for md-optgroup
4c47a25 
Adds support for `md-optgroup` in `md-autocomplete` by:
* Changing the `@ViewChild` query to pick up descendant options.
* Tweaking the keyboard scrolling to handle having group labels before options.

Fixes angular#5581.
@crisbeto crisbeto mentioned this issue Jul 8, 2017
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 8, 2017
@crisbeto
feat(autocomplete): support for md-optgroup
8ad659f 
Adds support for `md-optgroup` in `md-autocomplete` by:
* Changing the `@ViewChild` query to pick up descendant options.
* Tweaking the keyboard scrolling to handle having group labels before options.

Fixes angular#5581.
@tariknz
Copy link

tariknz commented Jul 19, 2017

I have a sad workaround for anyone waiting on this PR http://plnkr.co/edit/Q52JjTxtjjwW0r44n03l?p=preview

crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 25, 2017
@crisbeto
feat(autocomplete): support for md-optgroup
485479c 
Adds support for `md-optgroup` in `md-autocomplete` by:
* Changing the `@ViewChild` query to pick up descendant options.
* Tweaking the keyboard scrolling to handle having group labels before options.

Fixes angular#5581.
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 9, 2017
@crisbeto
feat(autocomplete): support for md-optgroup
fa9765b 
Adds support for `md-optgroup` in `md-autocomplete` by:
* Changing the `@ViewChild` query to pick up descendant options.
* Tweaking the keyboard scrolling to handle having group labels before options.

Fixes angular#5581.
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 18, 2017
@crisbeto
feat(autocomplete): support for md-optgroup
f16c078 
Adds support for `md-optgroup` in `md-autocomplete` by:
* Changing the `@ViewChild` query to pick up descendant options.
* Tweaking the keyboard scrolling to handle having group labels before options.

Fixes angular#5581.
kara pushed a commit that referenced this issue Aug 22, 2017
@crisbeto @kara
feat(autocomplete): support for md-optgroup (#5604)
e41d0f3 
Fixes #5581.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(autocomplete): support for md-optgroup crisbeto/material2
3 participants
@tariknz @alex321 @crisbeto