New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input): input module depends on forms module #5579

Merged

mmalerba merged 1 commit into angular:master from devversion:fix/input-depends-forms-module

Jul 9, 2017

Member

devversion commented Jul 7, 2017

The input module currently depends on the forms module. This is not necessary, because the input is able to work without NgModel or a FormControl as well.

Note: I didn't really modify the tests implementation (just moved them around).

Except one thing: I replaced the test class MdXXXBaseTestController with MdXXXWithId (because the tests that used MdXXXBaseTestController didn't really need a NgModel)


          fix(input): input module depends on forms module

4b6d427

* The input module currently depends on the forms module. This is not necessary, because the input is able to work without `NgModel` or a `FormControl` as well.

devversion added the pr: needs review label

devversion assigned mmalerba

googlebot added the cla: yes label

mmalerba added pr: lgtm action: merge and removed pr: needs review labels

mmalerba merged commit 44ca46a into angular:master

devversion deleted the fix/input-depends-forms-module branch

November 11, 2017 10:22

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

angular-automatic-lock-bot bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.