Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slider): slider module depends on forms module #5578

Merged

Conversation

devversion
Copy link
Member

@devversion devversion commented Jul 7, 2017

  • The slider module should not not import the FormsModule since the slider is designed to work without forms as well.

Note: Tests implementation has not been touched. They just got moved around.

* The slider module should not not import the `FormsModule` since the slider is designed to work without forms as well.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 7, 2017
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 7, 2017
@mmalerba mmalerba merged commit c14978b into angular:master Jul 9, 2017
@devversion devversion deleted the fix/slider-module-depends-forms branch November 11, 2017 10:22
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants