Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Addition of more then one Font Family for Typography Theming #5563

Closed
mtpultz opened this issue Jul 6, 2017 · 3 comments · Fixed by #5905
Closed

Feature: Addition of more then one Font Family for Typography Theming #5563

mtpultz opened this issue Jul 6, 2017 · 3 comments · Fixed by #5905
Assignees
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P4 A relatively minor issue that is not relevant to core functions

Comments

@mtpultz
Copy link

mtpultz commented Jul 6, 2017

Bug, feature request, or proposal:

Feature

What is the current behavior?

Typography theming allows a single font-family to be chosen using $font-family in the configuration

What is the use-case or motivation for changing an existing behavior?

Most applications and sites use more then one font-family. Typically h1 and/or h2 ($title) headers use a second font-family, but other then creating a second config there's no way to override the $title with a second font-family. Something like mat-typography-level taking another parameter to override the font-family, or an new mixin that does both level and font-family so the mixin name more closely reflects it's use.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular 4.2.5, Angular Material 2.0.0-beta.7, Windows 10

@jelbourn jelbourn added discussion feature This issue represents a new feature or feature request rather than a bug or bug fix labels Jul 7, 2017
@jelbourn
Copy link
Member

jelbourn commented Jul 7, 2017

@crisbeto thoughts?

@crisbeto
Copy link
Member

crisbeto commented Jul 7, 2017

It definitely makes sense. It shouldn't be too much trouble to support since it can fall back to the main font family.

@jelbourn jelbourn added P4 A relatively minor issue that is not relevant to core functions and removed discussion labels Jul 7, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 20, 2017
Allows for the `font-family` to be overwritten on a per-level basis. The default one is still taken from the base config.

Fixes angular#5563.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 20, 2017
Allows for the `font-family` to be overwritten on a per-level basis. The default one is still taken from the base config.

Fixes angular#5563.
kara pushed a commit that referenced this issue Jul 20, 2017
Allows for the `font-family` to be overwritten on a per-level basis. The default one is still taken from the base config.

Fixes #5563.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants