Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slide-toggle): slide-toggle module depends on forms module #5523

Merged
merged 1 commit into from Jul 9, 2017

Conversation

devversion
Copy link
Member

  • Currently the slide-toggle module always imports the FormsModule and therefore when treeshaking the FormsModule would be always included (even if FormsModule is not used at all)

Note: I'm working on similar PRs for the button-toggle and slider (need to check first)

* Currently the slide-toggle module always imports the `FormsModule` and therefore when treeshaking the `FormsModule` would be always included (even if FormsModule is not used at all)
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 5, 2017
@jelbourn
Copy link
Member

jelbourn commented Jul 6, 2017

@kara should we do this? Do you think components that are "forms compatible" should generally avoid bringing in the module?

@devversion
Copy link
Member Author

devversion commented Jul 6, 2017

@jelbourn Why should they depend on the FormsModule if they are really designed to work independently from the forms module?

The checkbox and radio are not depending on the FormsModule as well.

Stuff like the ControlValueAccessor are just definitions and won't cause the whole set of form directives to be included in the developers application.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 6, 2017
@mmalerba mmalerba merged commit d716b00 into angular:master Jul 9, 2017
@devversion devversion deleted the fix/slide-toggle-forms-module branch November 11, 2017 10:22
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants