Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): bigger height for underline on focus #5510

Merged
merged 1 commit into from Jul 14, 2017
Merged

fix(select): bigger height for underline on focus #5510

merged 1 commit into from Jul 14, 2017

Conversation

devversion
Copy link
Member

  • On focus the underline height should be as twice as big as the normal height. This is similar to the input component of Angular Material.
  • Replaces the aria-disabled attribute selectors with the mat-select-disabled class.

Fixes #5499

@devversion
fix(select): bigger height for underline on focus
08e7661 
* On focus the underline height should be as twice as big as the normal height. This is similar to the input component of Angular Material.
* Replaces the `aria-disabled` attribute selectors with the `mat-select-disabled` class.

Fixes angular#5499
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 5, 2017
kara
kara approved these changes Jul 5, 2017
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara removed their assignment Jul 5, 2017
@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 5, 2017
@mmalerba mmalerba added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jul 8, 2017
@mmalerba
Copy link
Contributor

mmalerba commented Jul 8, 2017

caretaker note: screenshot diffs need to be approved

@jelbourn jelbourn merged commit 78f0cec into angular:master Jul 14, 2017
@devversion devversion deleted the fix/underline-double-height branch November 11, 2017 10:22
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Underline of md-select is only 1px high when focused instead of 2px like md-input etc
5 participants
@devversion @mmalerba @kara @jelbourn @googlebot