fix(card): unable to bind to align attribute

[crisbeto]

Fixes not being able to bind to the align attribute on the md-card-actions.

Note: If we're okay with a breaking change, this may be simpler to do with a CSS class.

Fixes #5490.

[jelbourn]

I'm in general interested in changing behaviors like this to use just css classes, but it's something we'd have to do for the whole library. Any thoughts?

[crisbeto]

I prefer the CSS classes as well since these bindings just add unnecessary bloat. I can do it in the few other places that we have something similar, but it'll be a breaking change.

[jelbourn]

Might be good to first compile a list of places where we could do this and see how major the change would be

[crisbeto]

@jelbourn here's a list where changes would be necessary:

• align on md-card.
• align on md-dialog-actions.
• dense on md-list.
• fullscreen on md-sidenav.
• md-stretch-tabs on md-tabs.

There's also the mode input on md-progress-bar and md-progress-spinner, but I think that we should keep it there since the components need to react on mode changes. Should I go ahead with the list from above?

[jelbourn]

Let me see how widely they're used inside Google first

[jelbourn]

About:

• 6 uses on md-dialog-actions
• 32 for md-card-actions
• 20 for md-list
• I would want to skip sidenav anyway since we're working on changing that separately
• Tabs is hard to tell because the same property exists in material1

It would be pretty time consuming to update these, so updating the binding is how I would go for now. If we run out of more important stuff to do before end-of-beta then we can revisit.

[jelbourn]

LGTM

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}