Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MdMenu add an ability to configure options globally for all components of overlapTrigger=true|false in provider. #5479

Closed
vgoreiko opened this issue Jul 3, 2017 · 1 comment · Fixed by #5483
Closed

MdMenu add an ability to configure options globally for all components of overlapTrigger=true|false in provider. #5479

vgoreiko opened this issue Jul 3, 2017 · 1 comment · Fixed by #5483
Assignees
@crisbeto

Comments

@vgoreiko
Copy link

vgoreiko commented Jul 3, 2017 •
edited

Proposal.

It will be great to have ability of configuration of md-menu overlapping in providers. For example, as in the placeholder:
@NgModule({ providers: [ {provide: MD_PLACEHOLDER_GLOBAL_OPTIONS, useValue: { float: 'always' }} ] })

Currently it`s possible only to insert in every place of html using [overlapTrigger]="false" attribute or default value is 'true'.

This feature will add more flexibility of configuration md-menu globally.
@crisbeto crisbeto self-assigned this Jul 3, 2017
@crisbeto crisbeto added the has pr label Jul 3, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 3, 2017
@crisbeto
feat(menu): add injection token for overriding the default options
7e8d4b8 
Adds a new injection token that allows the consumer to override the default values for the `xPosition`, `yPosition` and `overlapTrigger` options.

Fixes angular#5479.
@crisbeto crisbeto mentioned this issue Jul 3, 2017
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 25, 2017
@crisbeto
feat(menu): add injection token for overriding the default options
c1d153c 
Adds a new injection token that allows the consumer to override the default values for the `xPosition`, `yPosition` and `overlapTrigger` options.

Fixes angular#5479.
andrewseguin pushed a commit that referenced this issue Jul 26, 2017
@crisbeto @andrewseguin
feat(menu): add injection token for overriding the default options (#…
3cb3945 
…5483)

* feat(menu): add injection token for overriding the default options

Adds a new injection token that allows the consumer to override the default values for the `xPosition`, `yPosition` and `overlapTrigger` options.

Fixes #5479.

* fix: unresolved merge conflict and pr feedback
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(menu): add injection token for overriding the default options crisbeto/material2
2 participants
@vgoreiko @crisbeto