fix(select): throwing additional errors if ngModel fails to initialize #5405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
reviewed
Jun 29, 2017
src/lib/select/select.spec.ts
Outdated
| const fixture = TestBed.createComponent(InvalidSelectInForm); | ||
|
|
||
| // The first change detection run will throw the "ngModel is missing a name" error. | ||
| expect(() => fixture.detectChanges()).toThrow(); |
There was a problem hiding this comment.
Can you pass a regex to toThrowError to check which specific error is being thrown here?
src/lib/select/select.spec.ts
Outdated
| expect(() => fixture.detectChanges()).toThrow(); | ||
|
|
||
| // The secound run shouldn't throw selection-model related errors. | ||
| expect(() => fixture.detectChanges()).not.toThrow(); |
crisbeto
force-pushed
the
5402/select-extra-errors
branch
from
4635ac1
to
0e86fec
Compare
If the user has an `md-select` with an `ngModel` that doesn't have a name inside a form, the forms module will throw an error, however Material will also start throwing errors, which may cause confusion. These changes add a null check so our errors don't get mixed up with the forms error. Fixes angular#5402.
crisbeto
force-pushed
the
5402/select-extra-errors
branch
from
0e86fec
to
4ea52e1
Compare
kara
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user has an
md-selectwith anngModelthat doesn't have a name inside a form, the forms module will throw an error, however Material will also start throwing errors, which may cause confusion. These changes add a null check so our errors don't get mixed up with the forms error.Fixes #5402.