fix(overlay): remove overlay container on destroy #5378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
approved these changes
Jun 27, 2017
| overlayRef.attach(fixture.componentInstance.templatePortal); | ||
| fixture.detectChanges(); | ||
|
|
||
| expect(document.body.querySelector('.cdk-overlay-container')) |
There was a problem hiding this comment.
Does this pass? I know that when I did the cleanup last time, there were still some divs left over between tests because the overlay container didn't have any cleanup logic.
crisbeto
added
pr: lgtm
action: merge
crisbeto
reviewed
Jun 27, 2017
| // injectable in a unit test. | ||
| overlayContainer.ngOnDestroy(); | ||
|
|
||
| expect(document.body.querySelector('.cdk-overlay-container')) |
There was a problem hiding this comment.
Can be just document.querySelector(...).
jelbourn
force-pushed
the
overlay-container-destroy
branch
from
4422c0f
to
1dccf5a
Compare
|
@crisbeto passed everywhere except browserstack. I changed the test to ensure that all overlay containers are remove with a |
mmalerba
added
pr: needs rebase
and removed
action: merge
|
needs rebase |
jelbourn
force-pushed
the
overlay-container-destroy
branch
from
1dccf5a
to
d1727da
Compare
jelbourn
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.