Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs): add theming and ability to set background color #5287

Merged
merged 1 commit into from Jul 22, 2017

Conversation

willshowell
Copy link
Contributor

@willshowell willshowell commented Jun 21, 2017

Fixes #1362
Fixes #2908
Fixes #5014

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 21, 2017
@willshowell
Copy link
Contributor Author

I definitely need to rework this to cut down on how much css is generated

@ocarreterom
Copy link
Contributor

How about something like:

$theme-colors: (
  primary: $primary,
  accent: $accent,
  warn: $warn
);

@each $name, $color in $theme-colors {
  &.mat-#{$name} {
    @include _mat-tab-label-focus($color);
    @include _mat-ink-bar($color);
  }

  &.mat-background-#{$name} {
    @include _mat-tab-label-focus($color);
    @include _mat-tabs-background($color);
 }

 &.mat-#{$name}.mat-background-#{$name} {
  @include _mat-ink-bar($color, default-contrast);
 }
}

@willshowell
Copy link
Contributor Author

cc @andrewseguin

@jelbourn
Copy link
Member

Review on this one might be delayed a bit (Andrew is wrapping up initial data table stuff)

@willshowell
Copy link
Contributor Author

@jelbourn fair, thank you for the update

Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the thorough work and your patience for the review. One suggestion, can you rename the background input to backgroundColor? Also, you'll need to rebase

@willshowell
Copy link
Contributor Author

@andrewseguin done, PTAL

@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 14, 2017
@kara kara removed the action: merge The PR is ready for merge by the caretaker label Jul 20, 2017
@kara kara assigned willshowell and unassigned andrewseguin Jul 20, 2017
@kara
Copy link
Contributor

kara commented Jul 20, 2017

@willshowell Can you rebase again? Sorry!

@willshowell
Copy link
Contributor Author

@kara done!

- Rework sass for smaller output

- make mixin base classes docs private (angular#5301)

- Use each directive for less repetition

- Rename background to backgroundColor
@kara kara added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Jul 22, 2017
@kara kara merged commit 374aaff into angular:master Jul 22, 2017
@willshowell willshowell deleted the feat/inverted-tabs branch July 22, 2017 18:47
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tabs customization [tabs] md-tab-group theming [Tabs] Inverted md-tabs style
6 participants