fix(autocomplete): reopening when clicking an option in IE #5172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
approved these changes
Jun 16, 2017
| @@ -78,7 +78,9 @@ export function getMdAutocompleteMissingPanelError(): Error { | |||
| '[attr.aria-activedescendant]': 'activeOption?.id', | |||
| '[attr.aria-expanded]': 'panelOpen.toString()', | |||
| '[attr.aria-owns]': 'autocomplete?.id', | |||
| '(focus)': 'openPanel()', | |||
| // Note: we use `focusin`, as opposed to `focus`, in order to open the panel | |||
| // a little earlier. This avoids issues where IE delays the focusing the input. | |||
There was a problem hiding this comment.
Typo: IE delays the focusing the input -> IE delays the focusing of the input
Fixes an issue that caused IE to reopen the autocomplete panel if the user clicks to select an item. It seems that IE can delay refocusing the input after the panel has been closed, which causes the focus handler to reopen it. Fixes angular#5165.
crisbeto
force-pushed
the
5165/ie-autocomplete-close-on-click
branch
from
08c7ae0
to
a763fd6
Compare
jelbourn
added
the
merge: caretaker note
|
Caretaker note: one team has a test utility that fires a fake focus event and tests that the autocomplete is open; changing it to also do |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue that caused IE to reopen the autocomplete panel if the user clicks to select an item. It seems that IE can delay refocusing the input after the panel has been closed, which causes the focus handler to reopen it.
Fixes #5165.