New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(button-toggle): Fix standalone button toggle style #5121
Conversation
@@ -7,6 +7,7 @@ $mat-button-toggle-padding: 0 16px !default; | |||
$mat-button-toggle-height: 36px !default; | |||
$mat-button-toggle-border-radius: 2px !default; | |||
|
|||
:not(.mat-button-toggle-group) > .mat-button-toggle, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we do this instead by having a css class like mat-button-toggle-standalone
that is applied via host binding?
host: {
'[class.mat-button-toggle-standalone]': '!buttonToggleGroup',
}
That way the styles will have a much lower specificity and will be easier to override
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Changed to host binding.
0fd9bb5
to
c23f0b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Add styles for standalone button-toggle without any button-toggle-group.
Fixes #4969