Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(list): don't handle events when modifier key is pressed #14313

Merged
merged 1 commit into from Nov 29, 2018
Merged

fix(list): don't handle events when modifier key is pressed #14313

merged 1 commit into from Nov 29, 2018

Conversation

crisbeto
Copy link
Member

Doesn't preventDefault and handle ENTER/SPACE/HOME/END keyboard events when a modifier is pressed, in order to avoid clashing with native OS shortcuts.

@crisbeto crisbeto added the in progress This issue is currently in progress label Nov 28, 2018
@crisbeto crisbeto self-assigned this Nov 28, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 28, 2018
@crisbeto
fix(list): don't handle events when modifier key is pressed
e911efb 
Doesn't `preventDefault` and handle ENTER/SPACE/HOME/END keyboard events when a modifier is pressed, in order to avoid clashing with native OS shortcuts.
devversion
devversion approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added target: patch This PR is targeted for the next patch release and removed in progress This issue is currently in progress labels Nov 28, 2018
@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 28, 2018
@crisbeto crisbeto assigned jelbourn and devversion and unassigned crisbeto Nov 28, 2018
@jelbourn jelbourn merged commit 2e7a039 into angular:master Nov 29, 2018
jelbourn pushed a commit that referenced this pull request Dec 3, 2018
@crisbeto @jelbourn
fix(list): don't handle events when modifier key is pressed (#14313)
0c7ce7a 
Doesn't `preventDefault` and handle ENTER/SPACE/HOME/END keyboard events when a modifier is pressed, in order to avoid clashing with native OS shortcuts.
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@crisbeto @josephperrott
fix(list): don't handle events when modifier key is pressed (angular#…
4f91f7b 
…14313)

Doesn't `preventDefault` and handle ENTER/SPACE/HOME/END keyboard events when a modifier is pressed, in order to avoid clashing with native OS shortcuts.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crisbeto @devversion @jelbourn @googlebot