Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slide-toggle): label not being read out by JAWS #14304

Merged
merged 1 commit into from Nov 28, 2018

Conversation

crisbeto
Copy link
Member

Along the same lines as #4610. Adds an extra element to allow for JAWS to pick up the label.

Along the same lines as angular#4610. Adds an extra element to allow for JAWS to pick up the label.
@crisbeto crisbeto added Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Nov 27, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 27, 2018
@devversion
Copy link
Member

devversion commented Nov 27, 2018

Is there any information that explains why a span fixes that?

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JAWS is generally super picky and sometimes inscrutable

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 27, 2018
@ngbot
Copy link

ngbot bot commented Nov 27, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: tests_saucelabs" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I just would have preferred to have a comment that explains how this fixes the issue, but I assume this is more of just a workaround based on trial-and error.

@jelbourn jelbourn merged commit 47e7aac into angular:master Nov 28, 2018
jelbourn pushed a commit that referenced this pull request Dec 3, 2018
Along the same lines as #4610. Adds an extra element to allow for JAWS to pick up the label.
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
Along the same lines as angular#4610. Adds an extra element to allow for JAWS to pick up the label.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants