fix(a11y): don't handle disallowed modifier keys in typeahead mode #14301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Nov 27, 2018
| this._letterKeyStream.next(event.key.toLocaleUpperCase()); | ||
| } else if ((keyCode >= A && keyCode <= Z) || (keyCode >= ZERO && keyCode <= NINE)) { | ||
| this._letterKeyStream.next(String.fromCharCode(keyCode)); | ||
| if (isModifierAllowed) { |
There was a problem hiding this comment.
I suspect that shift should be acceptable here (with the intent being a capital letter). It works for the native select, at least.
Recently we switched to skip handling keyboard events with modifiers, unless the consumer opted into them explicitly. The changes weren't applied when in typeahead mode. Fixes angular#14274.
crisbeto
force-pushed
the
14274/key-manager-typeahead-modifiers
branch
from
4a647a5
to
f38b082
Compare
jelbourn
added
pr: lgtm
action: merge
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…ngular#14301) Recently we switched to skip handling keyboard events with modifiers, unless the consumer opted into them explicitly. The changes weren't applied when in typeahead mode. Fixes angular#14274.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we switched to skip handling keyboard events with modifiers, unless the consumer opted into them explicitly. The changes weren't applied when in typeahead mode.
Fixes #14274.