fix(badge): badge instances not being cleaned up on destroy #14265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the `MatBadge` instances not being collected once the view is destroyed. The issue comes from the fact that when an element is created through the `Renderer2`, Angular adds it to an index (see `DebugRenderer2`), however we never tell it that it should be removed.
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
jelbourn
pushed a commit
that referenced
this pull request
Dec 3, 2018
Fixes the `MatBadge` instances not being collected once the view is destroyed. The issue comes from the fact that when an element is created through the `Renderer2`, Angular adds it to an index (see `DebugRenderer2`), however we never tell it that it should be removed.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…14265) Fixes the `MatBadge` instances not being collected once the view is destroyed. The issue comes from the fact that when an element is created through the `Renderer2`, Angular adds it to an index (see `DebugRenderer2`), however we never tell it that it should be removed.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
MatBadgeinstances not being collected once the view is destroyed. The issue comes from the fact that when an element is created through theRenderer2, Angular adds it to an index (seeDebugRenderer2), however we never tell it that it should be removed.