Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slide-toggle): label not being read out by screen reader on IE #14259

Merged
merged 1 commit into from Nov 27, 2018

Conversation

crisbeto
Copy link
Member

Fixes the label of a slide toggle not being read out by NVDA on IE, because the label element isn't pointing to the input.

Fixes the label of a slide toggle not being read out by NVDA on IE, because the `label` element isn't pointing to the `input`.
@crisbeto crisbeto added Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Nov 24, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 24, 2018
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically the input wrapped inside of a <label> should be automatically associated with the label. Nevertheless, being explicit doesn't hurt. LGTM

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 24, 2018
@ngbot
Copy link

ngbot bot commented Nov 24, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: tests_saucelabs" is failing
    pending status "ci/circleci: bazel_build_test" is pending
    pending status "ci/circleci: tests_local_browsers" is pending
    pending status "ci/circleci: tests_browserstack" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@crisbeto
Copy link
Member Author

Yeah wrapping it should be enough, but it doesn't look like that's the case in IE. We've been doing the same in checkbox and radio already.

@jelbourn jelbourn merged commit 136dfa8 into angular:master Nov 27, 2018
jelbourn pushed a commit that referenced this pull request Dec 3, 2018
…14259)

Fixes the label of a slide toggle not being read out by NVDA on IE, because the `label` element isn't pointing to the `input`.
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
…ngular#14259)

Fixes the label of a slide toggle not being read out by NVDA on IE, because the `label` element isn't pointing to the `input`.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants