fix(chips): invert focus overlay on dark theme #14204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similarly to `mat-button`, inverts the focus overlay color on a dark theme. Currently we always use an opaque black which can be mistaken for the disabled color on dark themes.
googlebot
added
the
cla: yes
josephperrott
added
pr: lgtm
action: merge
jelbourn
pushed a commit
that referenced
this pull request
Dec 3, 2018
Similarly to `mat-button`, inverts the focus overlay color on a dark theme. Currently we always use an opaque black which can be mistaken for the disabled color on dark themes.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
Similarly to `mat-button`, inverts the focus overlay color on a dark theme. Currently we always use an opaque black which can be mistaken for the disabled color on dark themes.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to
mat-button, inverts the focus overlay color on a dark theme. Currently we always use an opaque black which can be mistaken for the disabled color on dark themes.For reference, this is what it looks like on master. The first one is hovered, the last one is disabled:
