fix(scrolling): default to vertical CSS class for invalid orientation #14145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there are some structural styles that depend on the
cdk-virtual-scroll-orientation-*
classes, it's important that at least one of them is on the element at any time. Currently the user can end up with none if they did something likeorientation="horizontal-with-a-typo"
. These changes default to vertical, unless the value ishorizontal
which mirrors all the internal logic.Also adds some test coverage that the classes are included correctly.