Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepper): showing hover state after tap on touch devices #14074

Merged
merged 1 commit into from Nov 27, 2018

Conversation

crisbeto
Copy link
Member

Fixes the :hover state of the step header lingering on the element after a tap on a touch device.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Nov 10, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 10, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 12, 2018
@andrewseguin
Copy link
Contributor

Can you re-push to reactivate the CircleCI? Otherwise internal tests are green and this is ready to be merged

Fixes the `:hover` state of the step header lingering on the element after a tap on a touch device.
@crisbeto
Copy link
Member Author

Done @andrewseguin.

@jelbourn jelbourn merged commit 09dec49 into angular:master Nov 27, 2018
jelbourn pushed a commit that referenced this pull request Dec 3, 2018
Fixes the `:hover` state of the step header lingering on the element after a tap on a touch device.
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
…#14074)

Fixes the `:hover` state of the step header lingering on the element after a tap on a touch device.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants