fix(checkbox): poor color contrast for disabled checkbox #14044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
Accessibility
crisbeto
requested review from
devversion,
jelbourn and
josephperrott
as code owners
googlebot
added
the
cla: yes
devversion
added
pr: lgtm
action: merge
jelbourn
approved these changes
Nov 8, 2018
josephperrott
requested changes
Nov 12, 2018
| @@ -73,7 +74,7 @@ | |||
| } | |||
|
|
|||
| .mat-checkbox-label { | |||
| color: $disabled-color; | |||
| color: mat-color($foreground, disabled-text); | |||
There was a problem hiding this comment.
It turns out that the contrast of disabled-text in dark themes doesn't meet a11y standards.
We should use secondary-text here for now.
josephperrott
removed
the
action: merge
Fixes some poor color contrast on the text of a disabled checkbox. The issue comes from the fact that it was using a custom color rather than the one from theme.
crisbeto
force-pushed
the
disabled-checkbox-contrast
branch
from
acea693
to
81f1911
Compare
jelbourn
pushed a commit
that referenced
this pull request
Dec 3, 2018
Fixes some poor color contrast on the text of a disabled checkbox. The issue comes from the fact that it was using a custom color rather than the one from theme.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
Fixes some poor color contrast on the text of a disabled checkbox. The issue comes from the fact that it was using a custom color rather than the one from theme.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some poor color contrast on the text of a disabled checkbox. The issue comes from the fact that it was using a custom color rather than the one from theme.
For reference (top one is what we have in master):
