fix(chips): invalid aria-selected value for non-selectable chip (#6544)

angular · Aug 22, 2017 · 90fc300 · 90fc300
1 parent 1f4a962
commit 90fc300
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/src/lib/chips/chip.spec.ts b/src/lib/chips/chip.spec.ts
@@ -194,13 +194,8 @@ describe('Chips', () => {
           expect(testComponent.chipSelect).not.toHaveBeenCalled();
         });
 
-        it('should have empty aria-selected', () => {
-          expect(chipNativeElement.getAttribute('aria-selected')).toBeFalsy();
-
-          testComponent.selectable = true;
-          fixture.detectChanges();
-
-          expect(chipNativeElement.getAttribute('aria-selected')).toBe('false');
+        it('should not have the aria-selected attribute', () => {
+          expect(chipNativeElement.hasAttribute('aria-selected')).toBe(false);
         });
       });
 

diff --git a/src/lib/chips/chip.ts b/src/lib/chips/chip.ts
@@ -121,8 +121,8 @@ export class MdChip extends _MdChipMixinBase implements FocusableOption, OnDestr
   /** Emitted when the chip is destroyed. */
   @Output() destroy = new EventEmitter<MdChipEvent>();
 
-  get ariaSelected(): string {
-    return this.selectable ? this.selected.toString() : '';
+  get ariaSelected(): string | null {
+    return this.selectable ? this.selected.toString() : null;
   }
 
   constructor(renderer: Renderer2, elementRef: ElementRef) {