Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cdk]: overlay styles unavailable #7173

Closed
willshowell opened this issue Sep 19, 2017 · 8 comments
Closed

[cdk]: overlay styles unavailable #7173

willshowell opened this issue Sep 19, 2017 · 8 comments
Assignees
Labels
P2 The issue is important to a large percentage of users, with a workaround

Comments

@willshowell
Copy link
Contributor

Bug, feature request, or proposal:

Request (for tracking purposes)

Context

#6100

@jelbourn:

I plan on adding a overlay-prebuilt.scss in a follow-up PR

Other

While it looks like all of a11y is re-exported in the material bundle, cdk-a11y() doesn't seem to be a part of the cdk

https://github.com/angular/material2/blob/master/src/lib/core/a11y/_a11y.scss

cc @devversion

@devversion
Copy link
Member

@willshowell Good point. That should be something very important for CDK standalone usage.

@jelbourn
Copy link
Member

Yep, I forgot. @devversion could you take this? I probably won't have time this week.

@jelbourn jelbourn added the P2 The issue is important to a large percentage of users, with a workaround label Sep 19, 2017
@devversion
Copy link
Member

@jelbourn Sure, I should be able to implement it similar as for the material package. Do we want to have multiple SCSS files for the different secondary entry-points? e.g.

  • _overlay.scss
  • _a11y.scss

@jelbourn
Copy link
Member

@devversion for anything w/ styles, we want a partial (e.g., _overlay.scss) and a concrete file (e.g. overlay-prebuilt.scss).

@jelbourn
Copy link
Member

Also worth mentioning that we don't want to call the concrete file overlay.scss because it would make imports from client scss ambiguous

@devversion
Copy link
Member

See: #7204

@devversion devversion self-assigned this Sep 25, 2017
@willshowell
Copy link
Contributor Author

closing via #7204

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Development

No branches or pull requests

3 participants