Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[md-slide-toggle] setting default value to true brings pristine: false #4968

Closed
e-cloud opened this issue Jun 5, 2017 · 4 comments
Closed

[md-slide-toggle] setting default value to true brings pristine: false #4968

e-cloud opened this issue Jun 5, 2017 · 4 comments
Assignees
@devversion
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@e-cloud
Copy link
Contributor

e-cloud commented Jun 5, 2017

Bug, feature request, or proposal:

BUG

What is the expected behavior?

default value with true should not affect the pristine state

What is the current behavior?

pristine state is changed

What are the steps to reproduce?

http://plnkr.co/edit/cCqjrY62mF1WKBSFPWeH?p=preview

What is the use-case or motivation for changing an existing behavior?

Current behavior is somehow disturbing form validation

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular-4.1.0, Material-2.0.0-beta-6, others are all
@devversion devversion self-assigned this Jun 5, 2017
@devversion devversion added has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Jun 5, 2017
devversion added a commit to devversion/material2 that referenced this issue Jun 5, 2017
@devversion
fix(slide-toggle): NgControl not pristine if initial value is set
c25989c 
* If a developer sets an initial value for the slide-toggle the NgControl of the slide-toggle will turn dirty. The slide-toggle should only turn dirty if the value changed after initialization.

Fixes angular#4968
@devversion devversion mentioned this issue Jun 5, 2017
Merged
devversion added a commit to devversion/material2 that referenced this issue Jun 8, 2017
@devversion
fix(slide-toggle): NgControl not pristine if initial value is set
504a5c3 
* If a developer sets an initial value for the slide-toggle the NgControl of the slide-toggle will turn dirty. The slide-toggle should only turn dirty if the value changed after initialization.

Fixes angular#4968
devversion added a commit to devversion/material2 that referenced this issue Jun 8, 2017
@devversion
fix(slide-toggle): NgControl not pristine if initial value is set
83c123c 
* If a developer sets an initial value for the slide-toggle the NgControl of the slide-toggle will turn dirty. The slide-toggle should only turn dirty if the value changed after initialization.

Fixes angular#4968
@e-cloud
Copy link
Contributor Author

e-cloud commented Jun 20, 2017

see #4220

@csvn
Copy link
Contributor

csvn commented Jul 25, 2017

http://plnkr.co/edit/ZENOfcELsWaaHwqRDqRR?p=preview

New releases of material broke plunker. This one shows the issue.

@devversion
Copy link
Member

This should be fixed with dfe10c3

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@devversion @e-cloud @csvn