You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please remove all imports starting with rxjs/add/... and replace them with the side-effect free version.
This will also mean that you can no longer expect the operators to be monkey-patched on the prototype which makes material code uglier, but the benefit is that the application developers will not hit cases where some operators are available and others aren't where the availability of operators can change via innocent refactoring of internals of Angular Material.
In other words by using rxjs/add imports, every call you make becomes part of your public api and the operator added in this way will have to be retained even when you stop using it because removing it would be a breaking change.
Bug, feature request, or proposal:
Please remove all imports starting with
rxjs/add/...
and replace them with the side-effect free version.This will also mean that you can no longer expect the operators to be monkey-patched on the prototype which makes material code uglier, but the benefit is that the application developers will not hit cases where some operators are available and others aren't where the availability of operators can change via innocent refactoring of internals of Angular Material.
In other words by using rxjs/add imports, every call you make becomes part of your public api and the operator added in this way will have to be retained even when you stop using it because removing it would be a breaking change.
What is the expected behavior?
Proper usage: example from
@angular/router
https://github.com/angular/angular/blob/5efc86069ff92d980bb460c15deccb1e0fff9363/packages/router/src/apply_redirects.ts#L10-L19What is the current behavior?
Example code with
rxjs/add/...
import: https://github.com/angular/material2/blob/c524438b70510af0a27fe4e53c1970b8a42f0705/src/lib/tooltip/tooltip.ts#L33there are several more importas like this throughout the repo:
Which versions of Angular, Material, OS, browsers are affected?
2.0.0-beta.2
Is there anything else we should know?
I'm working with @Blesh to fix this using something like a pipe operator: https://twitter.com/IgorMinar/status/844348523869016066
The text was updated successfully, but these errors were encountered: